Added Wasi2Configuration
#339
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsturtevant
reviewed
Aug 5, 2025
| using var store = new Store(engine); | ||
|
|
||
| var config = new Wasi2Configuration(); | ||
| config.WithInheritedStandardInput(); |
There was a problem hiding this comment.
Any reason to not test the other configs?
There was a problem hiding this comment.
I'll have a look at adding some more tests later today
There was a problem hiding this comment.
I have added some more coverage (just calling other WithInheritedX methods).
I'm not really happy about these tests though - they don't actually assert anything!
Ideally I guess we'd need a WASI2.wat test file that reads some input, logs some out and logs some error output. Then we could assert that all of that is written to the correct outputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Wasi2Configurationwhich mirrorsWasiConfigurationfor WASI preview2.